From f0edfcc238e4e3857af65aff4f20fecc4014b1d9 Mon Sep 17 00:00:00 2001
From: Stas Guma <mcguma123@gmail.com>
Date: Wed, 1 May 2024 13:00:21 +0300
Subject: [PATCH] update the readme file

---
 readme.md                                     | 23 ++++++++++++++-----
 .../ui/ProfileSettings/ProfileSettings.tsx    | 13 ++++++-----
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/readme.md b/readme.md
index 9de6980..354148d 100644
--- a/readme.md
+++ b/readme.md
@@ -12,25 +12,35 @@ An open source frontend application built using the **React** ⚛️ and **Featu
 
 ## Live demo
 
-- [Application]()
+- [Application](https://frontend-react-adv.onrender.com/)
 - [Storybook](https://main--65c1748bed8d59893ba6a94f.chromatic.com/)
 
 ## About project
 
-This project will be an example of how to create a large-scale large project with clean code. Project based on a Feature-Sliced Design methodology.
+This project will be an example of how to create a large-scale large project with clean code. Project based on a Feature-Sliced Design methodology. Currently it doesn't have much functionality.
+In the future it will have all the basic features that most projects have.
 
 ## Features
 
-- Fully Typed (API adapters, catched error with type guards, form and env variables validators by valibot)
+- Typed (API adapters, form variables validators by valibot)
 - Developing by Feature-Sliced Design (Layers isolation and composition, Public API, DDD)
 - Fully API emulation with `Mock Config Server`
-- Storybook stories
+- Tested with `Vitest`, `Testing Library`
+- Storybook stories (Can change theme and language)
+- Mock API calls for tests and storybook with `Mock Service Worker`
+- Dark mode (Capability to easily implement a new theme)
+- Localization with `i18next`
+- Code splitting or lazy loading (Lazy load react components and redux store (reducers))
+- Linting TS and styles with `ESlint`, `Stylelint`
+- Regression testing with `Chromatic`
+- CI using GitHub Actions linting and testing on `push` and `pull request` actions
 
 # Roadmap
 
 App business logic:
 
-- [ ] Profile pages
+- [x] Profile pages
+- [ ] Upload avatar feature 
 
 Technologies:
 
@@ -40,6 +50,7 @@ Other:
 
 - [ ] Fix FSD errors
 - [ ] Fix TODO into code
+- [ ] Create a nice looking design
 
 ## Running locally
 
@@ -73,7 +84,7 @@ npm run dev
 yarn dev
 ```
 
-or start Storybook stand
+or start Storybook
 
 ```bash
 pnpm storybook
diff --git a/src/widgets/ProfileSettings/ui/ProfileSettings/ProfileSettings.tsx b/src/widgets/ProfileSettings/ui/ProfileSettings/ProfileSettings.tsx
index 8dd6fbe..53b0fe7 100644
--- a/src/widgets/ProfileSettings/ui/ProfileSettings/ProfileSettings.tsx
+++ b/src/widgets/ProfileSettings/ui/ProfileSettings/ProfileSettings.tsx
@@ -23,9 +23,10 @@ export const ProfileSettings = memo<IProps>(function ProfileSettings(props) {
   return (
     <div className={classNames(classes['profile-settings'], className)}>
       <Title variant="3">{t('My Profile')}</Title>
-      <div className={classNames(classes['profile-settings__section'])}>
-        {!isLoading && isSuccess
-          ? (
+
+      {!isLoading && isSuccess
+        ? (
+          <div className={classNames(classes['profile-settings__section'])}>
             <div className="row">
               <div className="col-auto">
                 <UploadAvatar imageUrl={data?.avatarUrl ?? ''} />
@@ -34,9 +35,9 @@ export const ProfileSettings = memo<IProps>(function ProfileSettings(props) {
                 <EditProfileForm data={data} />
               </div>
             </div>
-            )
-          : null}
-      </div>
+          </div>
+          )
+        : null}
     </div>
   );
 });