Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt AmountToSend #16703

Open
Tracked by #16696
Khushboo-dev-cpp opened this issue Nov 4, 2024 · 1 comment · May be fixed by #16819
Open
Tracked by #16696

Adapt AmountToSend #16703

Khushboo-dev-cpp opened this issue Nov 4, 2024 · 1 comment · May be fixed by #16819
Assignees
@Khushboo-dev-cpp
Labels
wallet-team

Comments

@Khushboo-dev-cpp
Copy link
Contributor

Khushboo-dev-cpp commented Nov 4, 2024 •
edited
Loading

Tasks created to adapt the AmountToSend to follow new simple send designs https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25202-37778&t=x7Ukt7ixxp7Ji84n-4
https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25660-238506&t=x7Ukt7ixxp7Ji84n-4

Enhancements:

  1. Removing the Recipient will receive side of the header leaves more room for ‘Amount to send’ value entry. This means progressive pt size reduction for longer digits is not required. Instead we should block entry when header area is filled given there is adequate room for 99% of realistic entries.
  2. The user should only be able to enter the maximum number of decimals specified by the token contract however.
  3. In case of max amount being clicked in case of ETH, this input area should display a tooltip with text "X ETH reserved for gas"
@Khushboo-dev-cpp Khushboo-dev-cpp mentioned this issue Nov 4, 2024
Open
20 tasks
@Khushboo-dev-cpp Khushboo-dev-cpp changed the title Adapt Network Selector Adapt AmountToSend Nov 4, 2024
@micieslak
Copy link
Member

AmountToSend seems to be good candidate to be reused here without any significant API changes. Visual layout needs to be adjusted. AmountToReceive, not refactored so far can be removed.

@Khushboo-dev-cpp Khushboo-dev-cpp self-assigned this Nov 8, 2024
Khushboo-dev-cpp added a commit that referenced this issue Nov 26, 2024
@Khushboo-dev-cpp
feat(@desktop/wallet): Adapt AmountToSend for Simple Send
c90caa0 
fixes #16703
@Khushboo-dev-cpp Khushboo-dev-cpp linked a pull request Nov 26, 2024 that will close this issue
Open
2 tasks
Khushboo-dev-cpp added a commit that referenced this issue Nov 27, 2024
@Khushboo-dev-cpp
feat(@desktop/wallet): Adapt AmountToSend for Simple Send
c681b8b 
fixes #16703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khushboo-dev-cpp Khushboo-dev-cpp

Labels
wallet-team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(@desktop/wallet): Adapt AmountToSend for Simple Send status-im/status-desktop
3 participants
@iurimatias @micieslak @Khushboo-dev-cpp