-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching messages gray status bar covers some part of clickable UI #5371
Comments
I've posted a possible solution over here, wdyt? #4345 |
@errorists I like it a lot! Here are more cases for you to think of:
Do you think that we can use the same pattern for these cases? |
@lukaszfryc Absolutely, as long as you're offline or otherwise can't establish a connection we should display this notification. I'll prepare a design doc with guidelines on how it can be used against both the light and blue navigation bars and with longer strings like those. |
We have different states like "Connecting to peers", "Fetching messages", "Offline", etc. @mandrigin is there one place in the code where we can find those states? |
Here's a solution I propose, whenever a snackbar is displayed we push down the underlying scroll view by the height of the snackbar like in this prototype |
@errorists I like this idea. Also, changing colors of the snackbar when something is done (Connecting... -> Connected) is a nice UX 👍 |
@errorists @yenda I like the idea of pushing the rest of the view down to create room for the snack bar, but to my mind these blue versions with rounded edges look like buttons. They're static as well, right? Changing back to grey might help. |
@rachelhamlin the buttons are just for the visualization they are not part of the design afaiu |
@yenda @errorists ahh I see, and I didn't click. 🙄 Cool, these look great. |
@yenda @siphiuel we didn't talk about this one during the call. Is it quick enough that we could do alongside TtT? |
- fix #5371 - fix #4345 - introduce "Connected..." status bar - introduce fetching animation - removes overlap of status bar with views - add animations for status bar Signed-off-by: yenda <[email protected]>
Description
Type: Bug
Summary: When the gray status bar appears it covers buttons and makes some of them not clickable. Maybe we could improve how this status bar looks like and where it appears. Note, that the bar can be clickable in some cases like "Tap to reconnect" when you lost connection with your peers.
Expected behavior
The status bar does not cover clickable UI.
Actual behavior
The status bar prevents user from clicking "Add to contact" button or clicking on the first row in chat.
Reproduction
Additional Information
The text was updated successfully, but these errors were encountered: