Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching messages gray status bar covers some part of clickable UI #5371

Closed
lukaszfryc opened this issue Aug 3, 2018 · 10 comments · Fixed by #7141
Closed

Fetching messages gray status bar covers some part of clickable UI #5371

lukaszfryc opened this issue Aug 3, 2018 · 10 comments · Fixed by #7141
Assignees

Comments

@lukaszfryc
Copy link
Contributor

lukaszfryc commented Aug 3, 2018

Description

Type: Bug

Summary: When the gray status bar appears it covers buttons and makes some of them not clickable. Maybe we could improve how this status bar looks like and where it appears. Note, that the bar can be clickable in some cases like "Tap to reconnect" when you lost connection with your peers.

Expected behavior

The status bar does not cover clickable UI.

Actual behavior

The status bar prevents user from clicking "Add to contact" button or clicking on the first row in chat.

Reproduction

  • Open Status
  • Go offline (turn on Airplane mode) and online again

Additional Information

  • Status version: 0.9.24
  • Operating System: Android, iOS
@errorists
Copy link
Contributor

I've posted a possible solution over here, wdyt? #4345

@lukaszfryc
Copy link
Contributor Author

@errorists I like it a lot!

Here are more cases for you to think of:

  1. Snackbar in wallet informing about temporary issues like:

  1. Snackbar saying "Cannot sign message in offline mode" in the sign message screen:

Do you think that we can use the same pattern for these cases?

@errorists
Copy link
Contributor

@lukaszfryc Absolutely, as long as you're offline or otherwise can't establish a connection we should display this notification. I'll prepare a design doc with guidelines on how it can be used against both the light and blue navigation bars and with longer strings like those.
Do we have a list somewhere with different types of connection states? I'd like to run it by @obi2020 to see if they can't be improved?

@lukaszfryc
Copy link
Contributor Author

We have different states like "Connecting to peers", "Fetching messages", "Offline", etc. @mandrigin is there one place in the code where we can find those states?

@errorists
Copy link
Contributor

Here's a solution I propose, whenever a snackbar is displayed we push down the underlying scroll view by the height of the snackbar like in this prototype
Think of it as adding / removing an additional top padding to the scroll children or offseting the scroll position by the height of the snackbar. Once the snackbar is gone, we push it up to the default location. When the 'Add to contacts' button is present, the snackbar should be rendered below it like so

@lukaszfryc
Copy link
Contributor Author

Here's a solution I propose, whenever a snackbar is displayed we push down the underlying scroll view by the height of the snackbar like in this prototype

@errorists I like this idea. Also, changing colors of the snackbar when something is done (Connecting... -> Connected) is a nice UX 👍

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Dec 18, 2018

@errorists @yenda I like the idea of pushing the rest of the view down to create room for the snack bar, but to my mind these blue versions with rounded edges look like buttons. They're static as well, right?

Changing back to grey might help.

@yenda
Copy link
Contributor

yenda commented Dec 18, 2018

@rachelhamlin the buttons are just for the visualization they are not part of the design afaiu

@rachelhamlin
Copy link
Contributor

@yenda @errorists ahh I see, and I didn't click. 🙄 Cool, these look great.

yenda pushed a commit that referenced this issue Dec 18, 2018
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar
@yenda yenda mentioned this issue Dec 19, 2018
yenda pushed a commit that referenced this issue Dec 19, 2018
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar
yenda pushed a commit that referenced this issue Jan 9, 2019
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar
@rachelhamlin
Copy link
Contributor

rachelhamlin commented Jan 9, 2019

@yenda @siphiuel we didn't talk about this one during the call. Is it quick enough that we could do alongside TtT?

yenda pushed a commit that referenced this issue Jan 24, 2019
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar
yenda pushed a commit that referenced this issue Jan 25, 2019
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar
yenda pushed a commit that referenced this issue Jan 25, 2019
- fix #5371
- fix #4345
- introduce "Connected..." status bar
- introduce fetching animation
- removes overlap of status bar with views
- add animations for status bar

Signed-off-by: yenda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants