Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

data.date.toUTCString #184

Closed
1 task done
weekwood opened this issue Apr 19, 2019 · 5 comments
Closed
1 task done

data.date.toUTCString #184

weekwood opened this issue Apr 19, 2019 · 5 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@weekwood
Copy link

  • I confirm that this is a issue rather than a question.

Bug report

I upgrade statusfy to 0.3.1 and try update-incident looks as breaks from my side. ti shows
TypeError: data.date.toUTCString is not a function
I put console.log to check data.date already string.

Version

@statusfy 0.3.1

Steps to reproduce

  1. npm run new-incident
  2. npm run update-incident

What is expected?

I can go though command line.

What is actually happening?

ℹ Reading configuration from config.toml 09:22:25
TypeError: data.date.toUTCString is not a function
at getIncidentsFromProject (/Users/diwu/Develop/statusfy/node_modules/@statusfy/core/lib/utils/functions.js:22:21)
at

I got this error.

Other relevant information

  • Your OS: Mac Os
  • Node.js version: 8.15.1
  • Which package manager did you use for the install?
    npm
@welcome
Copy link

welcome bot commented Apr 19, 2019

Thanks for opening this issue, a maintainer will get back to you shortly! Be sure to follow the issue template! 🤓

@nullpixel
Copy link

Can reproduce with the same steps

@juliomrqz juliomrqz added bug Something isn't working pinned Important Issues labels Apr 24, 2019
@asrob
Copy link

asrob commented May 10, 2019

Well, I'm not a JS ninja, so this can be insecure or not best practice but it seems to work.
I changed the line 22
from data.date.toUTCString()
to new Date(data.date).toUTCString().

Here is the output:

$ ./node_modules/.bin/statusfy update-incident
ℹ Reading configuration from config.js 17:18:10
? What incident do you want to update? (Use arrow keys)
❯ 2019-05-10_teszt-incidens.md > Teszt incidens (Fri, 10 May 2019 13:36:53 GMT)
README.md > undefined (Invalid Date)

@juliomrqz
Copy link
Owner

Hi, @weekwood. Try again with the latest version: v0.3.2-beta.1.

@juliomrqz juliomrqz removed the pinned Important Issues label Jun 13, 2019
@stale
Copy link

stale bot commented Jul 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 3, 2019
@stale stale bot closed this as completed Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants