Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: "p4 edit" on Save #17

Closed
hoovercj opened this issue May 12, 2016 · 5 comments
Closed

Enhancement: "p4 edit" on Save #17

hoovercj opened this issue May 12, 2016 · 5 comments
Assignees

Comments

@hoovercj
Copy link
Contributor

It would be nice to be able to automatically "p4 edit" a file on saving rather than manually running the command.

Should be very easy when a presave event gets added to the api. I'd be happy to add it.

microsoft/vscode#239

@stef-levesque
Copy link
Owner

That's exactly what we were discussing in #4 :)
Hopefully the insider build should provide it this month

@hoovercj
Copy link
Contributor Author

Oh great, awesome.

@mightycoco
Copy link

The p4 plugin in eclipse checks out the file in question as soon as you start typing (the files are read-only on disk before being checked out)

Maybe one could achieve the same using the workspace.onDidChangeTextDocument event? I'm not sure, when this get's fired, though...

@stef-levesque
Copy link
Owner

@mightycoco can you try to add "perforce.editOnFileModified": true in your settings and restart your editor ? This works fine for me.

@stef-levesque
Copy link
Owner

Closing for now, as @jel-massih contribution allows to editOnFileSave and editOnFileModified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants