Quote module name in object literal #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module names passed to the http-mock generator are dasherized and used as a property in an object literal. Therefore, they need to be quoted in case they contain a dash, which is not otherwise a valid identifier
|
LGTM, merge when green. |
|
👍 Windows build looks broken but I don't think it is related to this PR. |
bcardarella
added a commit
that referenced
this pull request
Aug 31, 2014
Quote module name in object literal
|
@bcardarella ya, it hasn't been green yet. Still working on that (slowly but surely) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module names passed to the http-mock generator are dasherized and
used as a property in an object literal. Therefore, they need to be
quoted in case they contain a dash, which is not otherwise a valid
identifier