Add config property to use pods as default structure. #2514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config property that inverts the meaning of the
--pod
flag. Current working name isusePodsByDefault
, but the name is less important than the functionality. The basic result is that we no longer need to use--pod
when generating and destroying blueprints.In blueprint install and uninstall, we check for the config property and return the inverse if
usePodsByDefault
is true.I still need to write a couple tests, but I wanted to put this up in case there were objections or suggestions on the property name. I also wanted to make sure this was the right way to go about the change, since it does seem like it could lead to some confusion if someone wasn't aware of the config property and it was set somehow.
I was also wondering if the value should be added to the app blueprint config, set to false by default.