-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration-test blueprint #985
Conversation
jgwhite
commented
Jun 11, 2014
@@ -0,0 +1,20 @@ | |||
import startApp from '../helpers/start-app'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to import Ember from 'ember';
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. Looks like the blueprint for tests/.jshintrc
isn’t strict enough.
👍 |
Will need a CHANGELOG entry also. |
Done and done 😄 |
it('integration-test foo', function() { | ||
return generate(['integration-test', 'foo']).then(function() { | ||
assertFile('tests/integration/foo-test.js', { | ||
contains: "import Ember from 'ember';\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its often nice to have assertFileEquals(inputFile, expectedFile)
this prevents us from having long strings in tests, that are hard to maintain. Those files can live in fixtures/<test-name>/<files>