Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for remapping of absolute paths in panic messages #1704

Open
brson opened this issue Nov 5, 2024 · 0 comments · May be fixed by #1786
Open

Add test case for remapping of absolute paths in panic messages #1704

brson opened this issue Nov 5, 2024 · 0 comments · May be fixed by #1786

Comments

@brson
Copy link
Contributor

brson commented Nov 5, 2024

In #1594 we added a fetature to remap absolute file paths in panic messages (and debuginfo) to relative paths, for reproducibility.

That issue did not land any tests - the feature is complicated to test, but we did discuss methods for testing it.

Also in that thread it was mentioned that we probably screwed up on windows specifically, because the feature as implemented does not work with spaces in paths, and windows home directories commonly contain spaces.

Let's write a test and fix the implementation on windows.

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Nov 5, 2024
brson added a commit to brson/soroban-cli that referenced this issue Dec 11, 2024
brson added a commit to brson/soroban-cli that referenced this issue Dec 11, 2024
brson added a commit to brson/soroban-cli that referenced this issue Dec 11, 2024
@brson brson linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog (Not Ready)
Development

Successfully merging a pull request may close this issue.

1 participant