Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Features On/Off #30

Open
DerekBuntin opened this issue Oct 18, 2023 · 2 comments
Open

Switching Features On/Off #30

DerekBuntin opened this issue Oct 18, 2023 · 2 comments

Comments

@DerekBuntin
Copy link

  1. It would be nice to be able to show or hide various aspects of the playlist such as the actual playlist itself, the full-screen button and next/previous buttons.

At the moment there is a script error when any of these elements are missing from the page.

The workaround is to add a style display:none or some CSS class to not display the elements.

  1. It would also be good to have the ability to add a class to the

    tags as are created dynamically.

  2. Add a flag to switch off console logs for events when in production

@stephenscaff
Copy link
Owner

Got it. Thanks. Will take a look and reply once I address.

@stephenscaff
Copy link
Owner

Okay

I just merged #33 which addresses:

  • wrapping playlist and player / full screen controls in proper conditional checks. No longer errors if exluded.
  • Consoles are behind a debug flag.

Before I close this, I'm not sure about

It would also be good to have the ability to add a class to the tags as are created dynamically.

Can you elaborate?
You can create your own playlist template and name stuff whatever you want. But, you're probably referring to something else?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants