Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The use of joint intervals in Gripper class is incorrect #385

Open
CSCSX opened this issue Aug 16, 2024 · 0 comments
Open

[BUG] The use of joint intervals in Gripper class is incorrect #385

CSCSX opened this issue Aug 16, 2024 · 0 comments

Comments

@CSCSX
Copy link

CSCSX commented Aug 16, 2024

Description of the bug

The specification of joint intervals

The related codes are in line 151~162 of https://github.com/stepjam/PyRep/blob/master/pyrep/objects/joint.py, where it specifies interval[0] is the joint minimum allowed value, interval[1] is the joint range (the maximum allowed value is interval[0]+interval[1].

The incorrect use of joint intervals

The related codes are in line 102 of https://github.com/stepjam/PyRep/blob/master/pyrep/robots/end_effectors/gripper.py, where it goes like joint_range = joint_intervals[:, 1] - joint_intervals[:, 0], appearing to treat joint_intervals[1] as the maximum allowed value instead of the joint range.

My suggestions on improvement

  1. Change the code of 102 of https://github.com/stepjam/PyRep/blob/master/pyrep/robots/end_effectors/gripper.py to joint_rage = joint_intervals[:, 1].
  2. Check similar incorrect use of joint intervals and then fix them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant