Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to provide ms_showStepper? #154

Closed
yccheok opened this issue Jun 24, 2017 · 6 comments
Closed

Does it make sense to provide ms_showStepper? #154

yccheok opened this issue Jun 24, 2017 · 6 comments
Assignees

Comments

@yccheok
Copy link
Contributor

yccheok commented Jun 24, 2017

Hi,

Currently, I do have a requirement where I need to hide the default stepper, and using my own custom progress bar.

This is how it looks like

screenshot_20170624-135536

This is my change on how I did it.

yccheok@acecf3c

Does it make sense to you? If you, I'm more than happy to send a pull request.

Thank you.
Cheok

@zawadz88
Copy link
Contributor

Hi @yccheok,
I think it makes sense to add such an option.
I'm wondering whether it wouldn't be better if this could be handled via a new stepper type though, e.g. none. What do you think?

@yccheok
Copy link
Contributor Author

yccheok commented Jun 27, 2017

Yes. Having "none" makes sense :) 👍

@yccheok
Copy link
Contributor Author

yccheok commented Jun 28, 2017

I had made change on none type, for our own production project usage.

yccheok@0a06894

I'm more than happy to send a PR if you like the change. Unfortunately, since I'm not able to configure unit test to run properly in my local, I'm not able to write a test for it.

@zawadz88
Copy link
Contributor

Please do :) I'll gladly review it and add it to the project.
Thanks!

@zawadz88
Copy link
Contributor

Hi @yccheok,
I've added the missing tests and a sample.
Thanks for contributing!

@zawadz88
Copy link
Contributor

Merged to develop, this will be a part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants