Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab - inactive tab color #207

Closed
nibo opened this issue Sep 22, 2017 · 5 comments
Closed

Tab - inactive tab color #207

nibo opened this issue Sep 22, 2017 · 5 comments
Assignees
Labels

Comments

@nibo
Copy link

nibo commented Sep 22, 2017

Hi...
I'd like to use a color with transparency as inactive color for the tabs.
I haven't found a solution by myself - is this possible?

@zawadz88
Copy link
Contributor

Hi @nibo,
This should be theoretically possible by specifying an alpha in the color, e.g.

app:ms_inactiveStepColor="#33ff0000"

however I see that there's some issue where a black background is visible underneath.

I'll investigate and get back to you.

@zawadz88 zawadz88 self-assigned this Sep 25, 2017
@nibo
Copy link
Author

nibo commented Sep 25, 2017

Thank's for reply...

i think the problem is:
mStepIconBackground.setColorFilter(mUnselectedColor);
where the imageview user default : PorterDuff.Mode.SRC_ATOP

maybe a solution is to enable the "alpha" as value or change the method to "backgroundRessource"for the step background

@zawadz88 zawadz88 added the bug label Sep 25, 2017
@zawadz88
Copy link
Contributor

Thanks for the hint.
After changing mStepIconBackground.setColorFilter(mUnselectedColor) to mStepIconBackground.setColorFilter(mUnselectedColor, PorterDuff.Mode.SRC_IN) it seems to be fixed!
I'll submit a PR shortly.

@nibo
Copy link
Author

nibo commented Sep 26, 2017

Thats awesome - thank you!

@zawadz88
Copy link
Contributor

Fixed, this will be in 4.3.0. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants