Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error resolving @storybook/icons in v2.1.1 #22

Closed
cflee opened this issue Mar 6, 2024 · 11 comments
Closed

Error resolving @storybook/icons in v2.1.1 #22

cflee opened this issue Mar 6, 2024 · 11 comments

Comments

@cflee
Copy link

cflee commented Mar 6, 2024

After upgrading to [email protected] which pulls in [email protected], my storybook build is reporting this:

✘ [ERROR] Could not resolve "@storybook/icons"

    node_modules/storybook-i18n/dist/manager.js:4:26:
      4 │ import { GlobeIcon } from '@storybook/icons';
        ╵                           ~~~~~~~~~~~~~~~~~~

  You can mark the path "@storybook/icons" as external to exclude it from the bundle, which will
  remove this error.

This seems to be new usage of this package @storybook/icons in #21 – it was previously using Icons from @storybook/components. Is there some dependency change that needs to be done to include this package?

@stevensacks
Copy link
Owner

stevensacks commented Mar 7, 2024

Version 2.1.x is for Storybook 8 (which is currently in Beta).

You can downgrade back to 2.0.x to use with Storybook 7, or you can upgrade your Storybook to the beta 8 release.

@stevensacks
Copy link
Owner

Storybook 8 has been released.

@davideme
Copy link

This make us fail our CI/CD pipeline too, would have been nice to follow semantic versioning. Using version 3.0 for SB8 instead of 2.1

@stevensacks
Copy link
Owner

@davideme I apologize. You are correct. I will fix this by removing the 2.1 releases and replacing with 3.x.

@stevensacks stevensacks reopened this Mar 15, 2024
@stevensacks
Copy link
Owner

I have removed the 2.1 releases.

  • 2.x is Storybook 7
  • 3.x is Storybook 8

@anthonyminyungi
Copy link

anthonyminyungi commented Mar 15, 2024

스크린샷 2024-03-15 오후 5 07 05

This package's v2.1.1 and v2.1.2 are still downloadable from npm.
The package manager is still detecting and downloading those versions.
Could you unpublish those versions from the registry like releases?

@stevensacks
Copy link
Owner

Ah sorry. Yes, I’ll unpublish them.

@stevensacks stevensacks reopened this Mar 15, 2024
@stevensacks
Copy link
Owner

npm does not allow me to unpublish, but I have deprecated those versions. That's the best I can do.

I'm sorry for the inconvenience. In the future, I will be sure to bump the major version for new major versions of Storybook.

@anthonyminyungi
Copy link

@stevensacks Is there any possibility of adding a new version after 2.1.2 for Storybook 7?

We are using the ^2.0.10 version of storybook-react-i18next and it still gets an error because the versions(2.1.1 and 2.1.2) causing errors (because they depend on the same version of this package) are still installed automatically by the package manager even if they are deprecated on npm.

So I would like to check if there is a possibility that a new version of the package for Storybook 7 after 2.1.2 will be added so that we are okay to use the fixed version 2.0.10 of storybook-react-i18next to resolve the error.

@stevensacks
Copy link
Owner

Can you pin it to 2.0.10?

@anthonyminyungi
Copy link

@stevensacks Yes. If there is no plan for adding the new version in major 2, we'll use 2.0.10 as pinned while we're using Storybook 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants