From 44fac62976c6ea5bd9cdf7e9c82989a44c9970ae Mon Sep 17 00:00:00 2001 From: Steve Teahan Date: Mon, 13 Sep 2021 12:14:54 -0400 Subject: [PATCH] Replace easy_install usage with the pip equivalents easy_install (used with setup.py install) will install pre-releases which is unexpected and undesirable behavior. More information: https://github.com/pypa/setuptools/issues/855 --- README.md | 9 +++++---- dockerfiles/Dockerfile | 4 +++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f3831abedb..0c64ac4623 100644 --- a/README.md +++ b/README.md @@ -126,16 +126,17 @@ python3 -m venv venv source venv/bin/activate # make sure you are running the latest setuptools -python3 -m pip install --upgrade pip setuptools +pip install --upgrade pip setuptools ``` Install the package: ```sh -python3 setup.py install +pip install . -# or alternatively use this for a devel environment -python3 setup.py develop +# or use this for development mode so rebuild/reinstall isn't necessary after +# each change that is made during development +pip install -e . # optionally install all test/type dependencies - useful when writing tests, # auto-completion in your IDE, etc. diff --git a/dockerfiles/Dockerfile b/dockerfiles/Dockerfile index a7d7b4ea7a..e23253257d 100644 --- a/dockerfiles/Dockerfile +++ b/dockerfiles/Dockerfile @@ -7,7 +7,9 @@ COPY reconcile reconcile COPY tools tools COPY setup.py . -RUN python3 setup.py install +# setup.py install is not used because it will install pre-releases: +# https://github.com/pypa/setuptools/issues/855 +RUN python3 -m pip install . COPY dockerfiles/hack/run-integration.py /run-integration.py CMD [ "/run-integration.py" ]