Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support over a websocket #129

Open
ChiHsiang opened this issue Jul 19, 2016 · 3 comments
Open

Support over a websocket #129

ChiHsiang opened this issue Jul 19, 2016 · 3 comments

Comments

@ChiHsiang
Copy link

I have feature is need to use Stomp over Websocket. And gem is not support it.
Could you give some suggestions to me with extend it?

@gmallard
Copy link

This gem existed a long time before websockets.

I can not help you with modifications unless you:

  • Tell me what you are trying to do
  • Tell me why you are trying to do it
  • Tell me why you think this gem is an appropriate tool for that job
  • Tell me what alternatives you have considered

@ChiHsiang
Copy link
Author

ChiHsiang commented Aug 4, 2016

Hi @gmallard, thanks for response.

Because some third party services use native(Websocket) Javascript client to connection server, I hope it to support websocket then send stomp format frame.

I find stomp/lib/connection/utils#116 that create tcp socket. Could be create the websocket to connection?

@gmallard
Copy link

gmallard commented Aug 7, 2016

There is much more to this than just changing a connect.

Websockets are, after all a wrapping of a TCP connection. In some ways similar to STOMP. Just as 'SSL' connections wrap a TCP connection.

All of the websocket MUST / SHOULD kinds of behavior and implementation details are described in the primary Websocket RFC:

RFC 6455

Any implementation by this gem would of course not be compliant with the STOMP specification. Websockets were briefly discussed when the STOMP 1.2 specification was being discussed. However, that was one of several discussions what was postponed to "STOMP V2". See:

[STOMP Spec Issue}(https://github.com/stomp/stomp-spec/issues/13)

The idea of Websockets over STOMP is however, very interesting. And simple STOMP client libraries (this one is not simple) are fairly easy to write.

What you propose will not happen with this gem (at present). However, I do think that a new 'websockets-stomp' gem would be appropriate. And a lot of fun to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants