Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private includes from stomp.rb #84

Open
PaulGale opened this issue Oct 2, 2013 · 0 comments
Open

Remove private includes from stomp.rb #84

PaulGale opened this issue Oct 2, 2013 · 0 comments

Comments

@PaulGale
Copy link

PaulGale commented Oct 2, 2013

Is it possible to relocate the private (so called) require statements found in lib\stomp.rb to the files that need them?

For example relocate:

# Private methods in #Client
require 'client/utils' # private Client Utility methods

# Private methods in #Connection
require 'connection/utils' # private Connection Utility methods
require 'connection/netio' # private Network io methods
require 'connection/heartbeats' # private 1.1+ heartbeat related methods
require 'connection/utf8' # private 1.1+ UTF8 related methods

to lib\stomp\client.rb and lib\stomp\connection.rb as appropriate.

As the contents of these files are private methods the public interface of the gem is not altered in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant