Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Docker): use tini to handle kernel signals #2622

Merged

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Oct 26, 2024

Summary

Use tini to handle kernel signals for Node.js, per https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals

For example, this aids shutting down. In a Docker compose setup Docker will send SIGINT and wait ten seconds for the container to stop. Without tini, prism does not get the signal and the 10s timeout forces stopping. With tini, prism closes in under a second.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@PixnBits PixnBits requested a review from a team as a code owner October 26, 2024 19:44
@mnaumanali94 mnaumanali94 self-requested a review November 26, 2024 06:02
@mnaumanali94 mnaumanali94 merged commit c55d633 into stoplightio:master Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants