fix(Docker): use tini to handle kernel signals #2622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use tini to handle kernel signals for Node.js, per https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals
For example, this aids shutting down. In a Docker compose setup Docker will send SIGINT and wait ten seconds for the container to stop. Without tini, prism does not get the signal and the 10s timeout forces stopping. With tini, prism closes in under a second.
Checklist