Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quasar no longer provides CloseDialog directive #60

Open
wooliet opened this issue May 28, 2019 · 2 comments · May be fixed by #61
Open

Quasar no longer provides CloseDialog directive #60

wooliet opened this issue May 28, 2019 · 2 comments · May be fixed by #61
Assignees
@sirbeagle

Comments

@wooliet
Copy link
Contributor

wooliet commented May 28, 2019

CloseDialog directive is no longer provided by quasar and is relied on by component/calendar/CalendarEventDetail.vue.

This causes the following build error:

Error: Unknown import from Quasar: CloseDialog

Quasar repo rc2

@wooliet
Copy link
Contributor Author

wooliet commented May 28, 2019

Looking through Quasar history, there was a console log:

console.info('\n\n[Quasar] info: please rename v-close-dialog (deprecated) with v-close-popup')

@wooliet wooliet linked a pull request May 28, 2019 that will close this issue
Open
@sirbeagle sirbeagle self-assigned this May 30, 2019
@sirbeagle
Copy link
Collaborator

@wooliet I saw the pull request (thank you btw) but just to let you know I have a pretty commit brewing on this end that will move a bunch of files around. I'll address this issue as part of that commit which should be coming sometime this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirbeagle sirbeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace CloseDialog with ClosePopup directive wooliet/quasar-calendar
2 participants
@sirbeagle @wooliet