Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getstorybook CRNA support #1115

Closed
4 of 7 tasks
shilman opened this issue May 24, 2017 · 2 comments
Closed
4 of 7 tasks

Getstorybook CRNA support #1115

shilman opened this issue May 24, 2017 · 2 comments

Comments

@shilman
Copy link
Member

shilman commented May 24, 2017

why

Currently getstorybook requires a few extra steps to get working with create-react-native-app (aka CRNA). They are documented (excellently) here:

https://medium.com/@inyono/using-react-native-storybook-with-create-react-native-app-471e531bb128

what

Proposal for streamlining the setup process:

  • Simplify as much as possible:
    • Consolidate storybook/index.ios.js and storybook/index.android.js into index.js
    • Detect CRNA app and print out additional (minimal) manual step
  • Update docs: discuss why manual step and why manual step is necessary

Props to @orta and @tmeasday for helping figure this out and for @inyono for the awesome post.

@inyono
Copy link

inyono commented May 24, 2017

That would be so awesome :) Btw: https://github.com/serlo-org/serlo-abc has an updated version of the blog post that e.g. picks the real app entry on build. Feel free to ask if you need input or want help from me.

@ndelangen
Copy link
Member

Is this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants