Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install --save prop-types causes severe problems with CRNA storybook #1234

Closed
kdenz opened this issue Jun 9, 2017 · 2 comments
Closed

Comments

@kdenz
Copy link

kdenz commented Jun 9, 2017

I'm not sure if npm install of other packages will cause the same problem, I haven't tested that, but npm install --save prop-types to an out-of-the-box CRNA storybook app on RN 44, leads to loads of npm run storybook errors like Error: Can't resolve 'react' in '/Users/kmac/Desktop/storybook/react-native-multi-level-select/node_modules/react-modal/lib/components'

And in the end I had to remove prop-types and @storybook/react-native then rerun getstorybook for it to work again

@shilman
Copy link
Member

shilman commented Jun 9, 2017

Thanks @kdenz I'll check it out and see (1) whether I can reproduce the problem, and (2) whether I can make sense of what's going! It'll be a couple days though, so if anybody else wants to jump in here, go right ahead!

@danielduan
Copy link
Member

If this is still a problem on the latest versions, please reopen. The cli should now install prop-types by default.
https://github.com/storybooks/storybook/blob/master/lib/cli/generators/REACT_NATIVE/index.js#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants