-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the title
when Storybook is loading from "Webpack app" to "Storybook loading..."
#17709
Comments
Looks like it's configured here: https://github.com/jantimon/html-webpack-plugin#options |
Need to add a title property here: storybook/lib/manager-webpack4/src/presets/manager-preset.ts Lines 89 to 110 in c806e2b
and here: storybook/lib/manager-webpack5/src/presets/manager-preset.ts Lines 88 to 109 in c806e2b
|
@pmcelhaney Thanks! I will take care of this sometime this week! |
w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.10 containing PR #17935 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
When building storybook, the title shows "Webpack App". Can we change it to "Storybook loading..."?
I found the title referenced in these files, but they are untracked so are likely not where the change needs to be made:
lib/manager-webpack4/prebuilt/index.html
lib/manager-webpack5/prebuilt/index.html
The text was updated successfully, but these errors were encountered: