Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention new supported frameworks #2895

Merged
merged 4 commits into from
Feb 18, 2018
Merged

Mention new supported frameworks #2895

merged 4 commits into from
Feb 18, 2018

Conversation

Hypnosphi
Copy link
Member

No description provided.

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks documentation labels Jan 31, 2018
@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2863e6f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2895   +/-   ##
========================================
  Coverage          ?   37.5%           
========================================
  Files             ?     425           
  Lines             ?    9140           
  Branches          ?     869           
========================================
  Hits              ?    3428           
  Misses            ?    5199           
  Partials          ?     513

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2863e6f...751617f. Read the comment docs.

ROADMAP.md Outdated
@@ -57,7 +57,7 @@ That way you can write your stories how they are best, and preview them how you

We believe in the power of react, and think it's the right choice for a lot of projects.
But it's up to you and your team to decide your stack.
Unfortunately if you choose anything other then React or React-Native you can not use storybook.
Unfortunately if you choose anything other then React or React-Native or Vue or Angular you can not use storybook.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think somewhere should be a list of supported frameworks, and we will be able to refer to it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a good place for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the main README? Or a separate FRAMEWORKS.md ? I also wanted to push this
https://gist.github.com/igor-dv/d621819b0d772aea0df88608f74e4da3
somewhere.., So maybe to the same place =)

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants