Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to [email protected] #3332

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Migrate to [email protected] #3332

merged 3 commits into from
Apr 2, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3248

@Hypnosphi Hypnosphi requested a review from jbovenschen as a code owner April 1, 2018 12:40
@codecov
Copy link

codecov bot commented Apr 1, 2018 •
edited
Loading

Codecov Report

Merging #3332 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3332   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files         472      472           
  Lines       10159    10159           
  Branches      957      957           
=======================================
  Hits         3639     3639           
  Misses       5916     5916           
  Partials      604      604
Impacted Files Coverage Δ
addons/a11y/src/components/WrapStory.js 54.09% <0%> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
app/mithril/src/server/utils.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0227868...1d11dba. Read the comment docs.

igor-dv
igor-dv approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@Hypnosphi Hypnosphi merged commit eb4bc2a into master Apr 2, 2018
@Hypnosphi Hypnosphi deleted the upgrade-axe branch April 2, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-dv igor-dv igor-dv approved these changes

@jbovenschen jbovenschen Awaiting requested review from jbovenschen jbovenschen is a code owner

Assignees
No one assigned
Labels
addon: a11y dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @igor-dv @phated