-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framework] add ember support #4237
Conversation
7a5c2fc
to
5dc9150
Compare
This is super exciting! |
Generated by 🚫 dangerJS |
|
||
let appInstance; | ||
|
||
function render(options, el) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially the same as how component tests are setup and ran. I'd like to extract a primitive library that can be shared between the main @ember/test-helpers
and this project so that we can more easily support broad ranges of Ember applications (and reduce specific coupling in storybook itself).
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally think this would be something we could decouple. Something like @ember/setup
that would just handle setting up and exposing a booted application
5dc9150
to
0d44ee7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4237 +/- ##
=========================================
- Coverage 40.64% 40.15% -0.5%
=========================================
Files 498 507 +9
Lines 5875 5942 +67
Branches 785 791 +6
=========================================
- Hits 2388 2386 -2
- Misses 3109 3171 +62
- Partials 378 385 +7
Continue to review full report at Codecov.
|
0d44ee7
to
c559971
Compare
c559971
to
9ce9997
Compare
@Keraito @ndelangen thoughts on the current state? |
9aaa4f4
to
9badf6e
Compare
2955dc9
to
afea517
Compare
I updated the example gif and made the stories and intro make more sense in its context. (It used to say go to button and edit, now makes more sense for ember and the welcome-banner example) |
afea517
to
c44a219
Compare
Can you please add separate commits instead of squashing them each time? Right now it's impossible to review the new diff |
@Hypnosphi yes I can do that in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"build": "ember build", | ||
"build-storybook": "yarn build && cp -r public/* dist; build-storybook -s dist", | ||
"dev": "ember serve", | ||
"storybook": "yarn build && cp -r public/* dist; start-storybook -p 9009 -s dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why should it be built before using with dev mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to build a storybook you need an ember app to introspect on. It is because of the dynamic nature of ember where as react has an implicit import structure, you can build a component standalone, ember needs to register all components beforehand. Which is why we have the build before dev necessity.
@igor-dv added the needed links to #supported-frameworks and live-examples |
2d3fad7
to
2d7235e
Compare
5efcc42
to
7af2fc4
Compare
Issue: #2877
What I did
Added ember framework support
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps? yes
Does this need an update to the documentation? yes