Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make every implementation in DeployHelper use create3 #161

Open
Ramarti opened this issue Jun 6, 2024 · 0 comments
Open

Make every implementation in DeployHelper use create3 #161

Ramarti opened this issue Jun 6, 2024 · 0 comments

Comments

@Ramarti
Copy link

Ramarti commented Jun 6, 2024

Description and context

Implementation contracts (as in ERC1967 proxy + implementation) are deployed using new

impl = address(
            new DisputeModule(address(accessController), address(ipAssetRegistry), address(licenseRegistry))
        );

Create3 makes easier tracking contracts and versioning across chains, testnets, etc, having consistent addresses.
We should enjoy that benefit for implementation contracts too.

Definition of done

Every contract deployed by DeployHelper, immutable, proxy and implementations alike, must have the same addresses in different chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant