Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with rust 1.80.0 #182

Closed
VlkrS opened this issue Jul 29, 2024 · 3 comments
Closed

Does not build with rust 1.80.0 #182

VlkrS opened this issue Jul 29, 2024 · 3 comments

Comments

@VlkrS
Copy link
Contributor

VlkrS commented Jul 29, 2024

Environment

  • OS: OpenBSD
  • age-plugin-yubikey version: 0.4.0

What were you trying to do

Building with Rust 1.80.0

What happened

To make age-plugin-yubikey build with rust 1.80.0 the time crate needs to be updated, and probably several other dependencies as well. Do you think it's possible to bump the dependencies and put the result through CI to see if there's any fallout?

@semarie
Copy link

semarie commented Jul 29, 2024

for reference about the time crate breakage, see rust-lang/rust#125319

@str4d
Copy link
Owner

str4d commented Jul 30, 2024

rust-lang/rust#125319 (comment) implies that time 0.3.36 or later is required for the fix (in testing I only needed time 0.3.35). time 0.3.24 bumped its MSRV to 1.67, which means in order to fix compilation with Rust 1.80, I'm also forced to bump MSRV of this crate to 1.67.

I'll see if I can limit the breakage to there.

@VlkrS
Copy link
Contributor Author

VlkrS commented Jul 30, 2024

Thank you!

@str4d str4d closed this as completed in f0d8224 Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants