Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI tests to GitHub actions #148

Merged
merged 6 commits into from
Oct 30, 2019
Merged

Move CI tests to GitHub actions #148

merged 6 commits into from
Oct 30, 2019

Conversation

patrick91
Copy link
Member

This should make it easier to test under multiple python versions (ie 3.8 beta)

@botberry
Copy link
Member

botberry commented Sep 10, 2019

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Tests are now run on GitHub actions on both python 3.7 and python3.8 🐍

@patrick91 patrick91 force-pushed the feature/github-actions branch 2 times, most recently from 8dbd572 to 6d0c8af Compare September 10, 2019 14:22
@patrick91
Copy link
Member Author

This is blocked by GitHub not having beta python versions :( actions/setup-python#15

@marcoacierno
Copy link
Member

Can we merge it if it works and then update it once Github supports 3.8?

@patrick91
Copy link
Member Author

@marcoacierno I think we should try to add 3.8a on Circle CI and then when it is supported on GH Actions we can migrate :)

@patrick91 patrick91 marked this pull request as ready for review October 16, 2019 11:28
@patrick91 patrick91 force-pushed the feature/github-actions branch 6 times, most recently from 915f4c1 to 4ee0818 Compare October 28, 2019 09:29
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #148 into master will increase coverage by 4.71%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   90.66%   95.38%   +4.71%     
==========================================
  Files          23       54      +31     
  Lines         493     1755    +1262     
==========================================
+ Hits          447     1674    +1227     
- Misses         46       81      +35

@patrick91 patrick91 force-pushed the feature/github-actions branch 2 times, most recently from eb5e43f to f82b4a9 Compare October 28, 2019 10:15
@patrick91
Copy link
Member Author

This can be merged when uvloop 0.14 gets released (as it is broken on py38)

@patrick91 patrick91 merged commit 81a370e into master Oct 30, 2019
@patrick91 patrick91 deleted the feature/github-actions branch October 30, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants