Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of schema when description had double quotes #3112

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

patrick91
Copy link
Member

No description provided.

@botberry
Copy link
Member

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release fixes an issue when trying to generate code from a schema that
was using double quotes inside descriptions.

The following schema will now generate code correctly:

"""
A type of person or character within the "Star Wars" Universe.
"""
type Species {
  """
  The classification of this species, such as "mammal" or "reptile".
  """
  classification: String!
}

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #3112 (5f67366) into main (5503591) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3112   +/-   ##
=======================================
  Coverage   96.51%   96.52%           
=======================================
  Files         481      481           
  Lines       29602    29610    +8     
  Branches     3657     3658    +1     
=======================================
+ Hits        28571    28580    +9     
  Misses        846      846           
+ Partials      185      184    -1     

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2023

CodSpeed Performance Report

Merging #3112 will not alter performance

Comparing fix/double-quotes (5f67366) with main (5503591)

Summary

✅ 12 untouched benchmarks

@patrick91 patrick91 merged commit cbb5a92 into main Sep 21, 2023
59 checks passed
@patrick91 patrick91 deleted the fix/double-quotes branch September 21, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants