Use less cross-compilations in CI tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astraw
reviewed
Oct 28, 2022
astraw
reviewed
Mar 15, 2023
We aren't using any assembly code, but only the official C interface for our Android and MacOS implementation. It's exceedingly unlikely that the compilation for e.g. AArch64 could fail if it succeeds for x86-64.
Kijewski
force-pushed
the
pr-less-cross-compile
branch
from
ad444a1
to
e468f42
Compare
|
The link-time error for android was fixed in cross-rs, but the fix was not released, yet: cross-rs/cross#1222 (comment) |
|
I guess we only need to replace two lines in the changelog and we do a release: -## [0.1.54] - unreleased
+## [0.1.54] - 2023-03-21
### Changed
-- replace `winapi` dependency with `windows-sys` ([#91](https://github.com/strawlab/iana-time-zone/pull/91))
+- replace `winapi` dependency with `windows` ([#97](https://github.com/strawlab/iana-time-zone/pull/97))I you want I can do that tomorrow. |
astraw
approved these changes
Mar 21, 2023
|
Yes, it would be great if you do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't using any assembly code, but only the official C interface for our Android and MacOS implementation. It's exceedingly unlikely that the compilation for e.g. AArch64 could fail if it succeeds for x86-64.
Should hopefully resolve #80.