Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct list variable in useList #412

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix: use correct list variable in useList #412

merged 1 commit into from
Jun 25, 2019

Conversation

xiaoboost
Copy link
Contributor

Avoid referencing closure variables

@xiaoboost xiaoboost closed this Jun 25, 2019
@xiaoboost xiaoboost deleted the fix-uselist branch June 25, 2019 01:20
@streamich
Copy link
Owner

@xiaoboost why did you close it?

@xiaoboost
Copy link
Contributor Author

@streamich
Sorry……It's my mistake……
Is it because I deleted the original branch? or some other reason?
I didn't actively close this pr.

can I create a new pr?

@streamich
Copy link
Owner

can I create a new pr?

Of course you can.

@xiaoboost xiaoboost restored the fix-uselist branch June 25, 2019 12:58
@xiaoboost xiaoboost reopened this Jun 25, 2019
streamich
streamich approved these changes Jun 25, 2019
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamich streamich changed the title fix: useList fix: use correct list variable in useList Jun 25, 2019
@streamich streamich merged commit b937296 into streamich:master Jun 25, 2019
streamich pushed a commit that referenced this pull request Jun 27, 2019
@semantic-release-bot
chore(release): 9.7.2 [skip ci]
0ba46f9 
## [9.7.2](v9.7.1...v9.7.2) (2019-06-27)

### Bug Fixes

* save to localStorage only when state changes ([ba6d375](ba6d375))
* use correct list variable in useList ([#412](#412)) ([b937296](b937296))
@streamich
Copy link
Owner

🎉 This PR is included in version 9.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoboost @streamich