Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 2 commands: jump previous/next spell error #1198

Merged
merged 8 commits into from
Aug 26, 2021
Merged

add 2 commands: jump previous/next spell error #1198

merged 8 commits into from
Aug 26, 2021

Conversation

elazarcoh
Copy link
Contributor

Hi,
I implemented these 2 commands:

cSpell.goToNextSpellingError
cSpell.goToPreviousSpellingError

You probably have better names in mind rather than "Spelling Error", so feel free to change those.

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 26, 2021

Excellent!

Nicely done. Well done on picking up how things are already done.

A few comments:

  • It might be worth it to make 4 commands:
    1. goToNextSpellingError
    2. goToPreviousSpellingError
    3. goToNextSpellingErrorAndSuggest
    4. goToPreviousSpellingErrorAndSuggest

I think it is worth just having commands to move between the issues. Automatically making suggestions is a nice addition.

Jason3S
Jason3S reviewed Aug 26, 2021
View reviewed changes
packages/client/src/commands.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/client/src/commands.ts Outdated Show resolved Hide resolved
packages/client/src/commands.ts Outdated Show resolved Hide resolved
@Jason3S
Copy link
Collaborator

Jason3S commented Aug 26, 2021

Thank you for doing this. It helps a lot.

elazarcoh
elazarcoh commented Aug 26, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/client/src/commands.ts Outdated Show resolved Hide resolved
packages/client/src/commands.ts Outdated Show resolved Hide resolved
packages/client/src/commands.ts Outdated Show resolved Hide resolved
@elazarcoh
Copy link
Contributor Author

Note that I've added 2 more commands, and changed the message box type to info

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 26, 2021

I like it. It works well.

This fixes: #280
And helps with #565

@Jason3S Jason3S merged commit 165fb66 into streetsidesoftware:main Aug 26, 2021
@elazarcoh elazarcoh mentioned this pull request Aug 26, 2021
Closed
@Jason3S
Copy link
Collaborator

Jason3S commented Aug 27, 2021

@elazarcoh,

I have published your changes: Releases · streetsidesoftware/vscode-spell-checker.

I hope to release it to the VS Code Marketplace in a few days.

@elazarcoh elazarcoh deleted the add-go-to-next-prev-typos branch August 27, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason3S Jason3S Jason3S left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elazarcoh @Jason3S