fix: Fix add / remove locale from configuration #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Logic ### Scope When adding / removing locales, the scope is either Global or Workspace. Global - means it is possible to adjust any configuration. Workspaces - means it is possible to adjust any configuration that is not Global. - Targets are presented from Locale to Global. - Targets _Inherit_ their values from Global to Local. ### Adding Locale 1. Only present targets that will have an impact. 1. If no targets will have an impact, then present any target that can be changed. 1. If there is only 1 target, then perform action without asking. ### Removing Locale 1. Only present targets that will have an impact. 1. If no targets will have an impact, do nothing. 1. If there is only 1 target, then perform action without asking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic
Scope
When adding / removing locales, the scope is either Global or Workspace.
Global - means it is possible to adjust any configuration.
Workspaces - means it is possible to adjust any configuration that is not Global.
Adding Locale
Removing Locale