fix: replaced call to fs.pathExists() with fs.existsSync()

[jeffb-sfdc]

Replaced call to fs.pathExists() with fs.existsSync().

Reasons:

1. pathExists() has been deprecated
2. My team writes an extension for VS Code. I sometimes need to turn on caught exceptions and uncaught exceptions, but this is impossible to do with the cspell extension installed, since findSettingsFiles() looks for a dozen different config files and thrown an exception for every file it can't find (and it does this every 10 seconds)

[Jason3S]

Thank you for picking up on this.

Please use fileExists from 'common-utils/file.js';

[jeffb-sfdc]

I looked into it, but fileExists() throws exceptions, which is the point if this PR. Any reason why not to use fs.pathExists()?

[Jason3S]

fs.existsSync will block, slowing the search down.

Under normal circumstances, fileExists should not throw an exception. It catches the exception thrown by fs.access and returns false.
https://github.com/streetsidesoftware/vscode-spell-checker/blob/main/packages/__utils/src/file.ts#L5

[Jason3S]

@jeffb-sfdc,

Forgive me, I had not fully read your reasons.

Reasons:

1. pathExists() has been deprecated

This file uses fs-extra where under the hood it uses fs.access to determine if the file exists. fs.acces is not deprecated, nor is fs-extra.pathExists.

2. My team writes an extension for VS Code. I sometimes need to turn on caught exceptions and uncaught exceptions, but this is impossible to do with the cspell extension installed, since findSettingsFiles() looks for a dozen different config files and thrown an exception for every file it can't find (and it does this every 10 seconds)

Yes, this can be very annoying. Let's see if another solution works for you. Changing the code from async to sync isn't a good option. This code exists because the VS Code file watcher had been very buggy and slow. I suspect that they many have fixed it by now. I'll take a look.

[Jason3S]

@jeffb-sfdc,

Please try https://github.com/streetsidesoftware/vscode-spell-checker/releases/tag/v2.0.14 to see if that fixes the issue.

[jeffb-sfdc]

@Jason3S It looks like v2.0.14 fixes the issue, and I'm going to close this PR.