-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amount
and label
to GooglePayLauncher
and GooglePayConfiguration
#7191
Merged
tillh-stripe
merged 9 commits into
master
from
tillh/google-pay-custom-amount-and-label
Sep 14, 2023
Merged
Add amount
and label
to GooglePayLauncher
and GooglePayConfiguration
#7191
tillh-stripe
merged 9 commits into
master
from
tillh/google-pay-custom-amount-and-label
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
from
August 23, 2023 14:13
093da55
to
77255c4
Compare
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
2 times, most recently
from
August 29, 2023 00:54
c143196
to
eb07b4a
Compare
tillh-stripe
changed the title
Add
Add Aug 29, 2023
amount
and amountLabel
to GooglePayLauncher for SIamount
and label
to GooglePayLauncher
and GooglePayConfiguration
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
4 times, most recently
from
September 8, 2023 15:11
f315259
to
4e7e30b
Compare
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
from
September 13, 2023 20:04
4e7e30b
to
f29ee2a
Compare
tillh-stripe
requested review from
jameswoo-stripe,
jaynewstrom-stripe and
samer-stripe
September 13, 2023 20:04
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
2 times, most recently
from
September 13, 2023 20:18
151b078
to
7a2ca50
Compare
tillh-stripe
force-pushed
the
tillh/google-pay-custom-amount-and-label
branch
from
September 13, 2023 20:20
7a2ca50
to
34771dd
Compare
...c/main/java/com/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncherContractV2.kt
Show resolved
Hide resolved
jaynewstrom-stripe
approved these changes
Sep 13, 2023
samer-stripe
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for providing a custom amount (for setup intents) and a custom label when opening the Google Pay bottom sheet.
For
GooglePayLauncher
, we add both properties topresentForSetupIntent()
and the label property topresentForPaymentIntent()
.For
GooglePayPaymentMethodLauncher
, we add the label property topresent()
, as the amount property already exists.For
PaymentSheet.GooglePayConfiguration
, we add both properties to the constructor. We also remove one redundant constructor.(cc @charliecruzan-stripe)
Motivation
MOBILE_APIREVIEW-53
Testing
Screenshots
Changelog