You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I haven't done any testing with this so I don't know if it represents an actual bug, but wanted to file this issue in case this was something the team was unaware of.
This timeout was introduced in Node.js v0.9.12 as 120 seconds, and did not change until v13.0.0 when it was switched to 0. There is of course a possibility that this change will be reverted before v14 is released, but it's worth keeping an eye on.
The text was updated successfully, but these errors were encountered:
@brandur-stripe@remi-stripe@richardm-stripe I think we should just change the default timeout to a hardcoded value of 80 seconds like we do in other client libraries. Does that sound good to everyone?
In Node.js v13.0.0 the default socket timeout has been set to 0.
Currently in this Library the default timeout is being set based on
require('http').createServer().timeout
.stripe-node/lib/stripe.js
Line 11 in 1a6cd58
The default previously was 120 seconds, under v13 it is no timeout by default aka a value of
0
.I noticed this when looking into #796
I haven't done any testing with this so I don't know if it represents an actual bug, but wanted to file this issue in case this was something the team was unaware of.
This timeout was introduced in Node.js v0.9.12 as 120 seconds, and did not change until v13.0.0 when it was switched to 0. There is of course a possibility that this change will be reverted before v14 is released, but it's worth keeping an eye on.
The text was updated successfully, but these errors were encountered: