Multiple API changes #1053
Merged
Multiple API changes #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Oct 26, 2020
| * A single-use `cvc_update` Token that represents a card CVC value. When provided, the CVC value will be verified during the card payment attempt. This parameter can only be provided during confirmation. | ||
| */ | ||
| cvc_token?: string; | ||
|
|
There was a problem hiding this comment.
This is what's really new
| @@ -205,12 +205,12 @@ declare module 'stripe' { | |||
| /** | |||
| * Inventory type. Possible values are `finite`, `bucket` (not quantified), and `infinite`. | |||
| */ | |||
| type?: Inventory.Type; | |||
| type: Inventory.Type; | |||
There was a problem hiding this comment.
This is new as it's now required in the types (the API always required it but it didn't reflect properly)
| /** | ||
| * The updated CVC value this token will represent. | ||
| */ | ||
| cvc_update?: TokenCreateParams.CvcUpdate; |
| * The CVC value, in string form. | ||
| */ | ||
| cvc: string; | ||
| } |
richardm-stripe
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple API changes:
Stripe.Emptyableas a typepayment_method_options[card][cvc_token]onPaymentIntentcvc_update[cvc]onTokencreationCodegen for openapi e215279
r? @richardm-stripe
cc @stripe/api-libraries