-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement/fix reverse iteration when iterating with ending_before #1100
Conversation
nice, can we get this merged please? |
We'll get to it in early January after the holidays! |
great, happy new year ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kaznovac, very grateful for this PR! Thank you especially for the tests. I just have one request to avoid .reverse()
.
Wrote a couple of extra tests while reviewing this to make sure I understood this change. You can merge them into your branch if you'd like, otherwise I will merge it afterwards: kaznovac/stripe-node@reverse-iteration...richardm-stripe:richardm-reverse-iteration Lots of whitespace noise because I added a and |
Add some autoPagination-related tests
Thank you so much for the contribution @kaznovac, we'll get this released shortly. |
@kaznovac @richardm-stripe thank you guys 🍺 |
fixes #1090
implementation, similarly to stripe/stripe-dotnet#1848, reverses the order of the response list to prevent unexpected iteration
(example without reversing described in https://github.com/stripe/stripe-dotnet/pull/1854/files#r350498976)