Add client name property to HttpClient. #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-client-name
branch
from
2a7a83b
to
6eb30ee
Compare
|
Added a test. I also moved it out of the constructor and into a hard coded method, since it's unnecessary to hold on to the state and regardless implementations that don't include this will fail. Happy to move it back if you'd rather. PTAL @richardm-stripe |
richardm-stripe
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
Adds a client name property to be implemented by
HttpClientwhich will be shipped in the user agent under thehttplibproperty similar to Python.