Add an HTTP client which uses fetch. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-fetch-client
branch
from
445ec51
to
8061bdf
Compare
dcr-stripe
force-pushed
the
dcr-fetch-client
branch
from
8061bdf
to
01b9ff2
Compare
dcr-stripe
changed the title
lib/net/FetchHttpClient.js
Outdated
| this._fetchFn = fetchFn; | ||
| } | ||
|
|
||
| /* eslint-disable class-methods-use-this */ |
There was a problem hiding this comment.
Shall we globally disable this rule? We seem to violate it all the time and I don't really agree with it.
Co-authored-by: Richard Marmorstein <[email protected]>
| const headersObj = {}; | ||
|
|
||
| for (const entry of headers) { | ||
| headersObj[entry[0]] = entry[1]; |
There was a problem hiding this comment.
WDYT of throwing an exception here if entry is not an array with two entries?
I think maybe it's worth being more defensive here because fetchFn is injected
| }); | ||
| }); | ||
|
|
||
| it('toJSON accumulates all data chunks in utf-8 encoding', async () => { |
richardm-stripe
approved these changes
Sep 8, 2021
|
Added fixes. PTAL @richardm-stripe ? Thanks for the feedback! |
richardm-stripe
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify
r? @richardm-stripe
Summary
Adds an
HttpClientimplementation that uses the Fetch API.This paves the way for unblocking #997.
Test plan
The common tests are shared between NodeHttpClient and FetchHttpClient to make sure both meet the requirements for the interface (modulo some streaming/raw response tests, as this is implementation-dependant). In order to test
fetchas part of our Node testing environment, the node-fetch polyfill is used.