Add typed createFetchHttpClient function. #1273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify
r? @richardm-stripe
Summary
Adds a
createFetchHttpClient
function similar tocreateNodeHttpClient
and expose this on theStripe
object. This lets us type the client creation and eliminate an extra import in code while also not forcing all code to require theFetchHttpClient
unless needed.Implementation change
This changes:
to:
Test plan
Updated typescript tests. Also confirmed that this doesn't interfere with regular node implementations by cloning https://github.com/stripe-samples/accept-a-payment/tree/main/custom-payment-flow/server/node-typescript, pointing it to this branch, and making sure typescript compiles.