feat(http-client): retry closed connection errors

[bpinto]

Changes made

Requests that fail with closed connection errors (ECONNRESET, EPIPE) are now automatically retried.

• ECONNRESET (Connection reset by peer): A connection was forcibly
  closed by a peer.closed by a peer. This normally results from a loss
  of the connection on the remote socket due to a timeout or reboot.
  Commonly encountered via the http and net modules.

• EPIPE (Broken pipe): A write on a pipe, socket, or FIFO for which
  there is no process to read the data. Commonly encountered at the net
  and http layers, indicative that the remote side of the stream being
  written to has been closed.

Purpose of changes

Fixes: #1040

From my perspective, handling these errors by retrying is likely the proper approach, and shouldn't necessarily be viewed as a workaround, or masking an underlying issue, because it is expected/unavoidable that these broken connections will come to exist, and there doesn't seem to be an obvious way of asking Node "how long has it been since the last keep-alive probe on this connection" besides writing to the connection and triggering the error.

At the same time, I think we should look into the possibility of making stripe-node handle errors like this by default/more transparently, so that users don't have to configure the retries themselves. That seems to be what Amazon started doing for errors like this for their own SDKs about a month ago (thank you @hisham for linking to that issue, by the way).

See: #1040 (comment)

Depends on #1335

TODO

• Should this become optional through a config option?
• Update documentation.
• Test this change on a lambda environment.

[richardm-stripe]

Hello @bpinto,

Thank you so much submitting this - I am quite excited about this. I will try to have a more detailed look at this next week.

[bpinto]

Hey @richardm-stripe 👋

I'm excited about this change as well! Please let me know what you think we could do differently.

P.S.: I've noticed tests are failing and I'll be looking at those soon, I'm flying this Wednesday so I might not have to look at this until later this week.

[richardm-stripe]

Hi @bpinto, just to keep you updated, we are planning on merging this change in the next major as we're a bit hesitant to change the default retry behavior in a minor.

[bpinto]

Totally understandable, thanks for the follow up.