Add support for the TaxId resource and APIs #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
changed the title
|
This is now ready to be reviewed. |
lib/resources/TaxIds.js
Outdated
| * This streamlines the API specifically for the case of accessing a tax id | ||
| * on a returned customer object. | ||
| * | ||
| * E.g. customerObject.tax_id.retrieve(taxIdId) |
There was a problem hiding this comment.
should this be customerObject.tax_ids (the id[s])?
There was a problem hiding this comment.
I'll be honest, this comment makes little sense to me (the library really needs to be cleaned-up/rewritten :p) but likely
|
ptal @remi-stripe |
remi-stripe
force-pushed
the
remi-add-tax-ids
branch
from
1f4941f
to
25d8cbc
Compare
|
@mickjermsurawong-stripe Nice catch. Fixed. PTAL |
|
LGTM |
This was referenced Nov 29, 2019
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries