Multiple API changes #899
Merged
Multiple API changes #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
May 22, 2020
| @@ -14,6 +14,8 @@ declare module 'stripe' { | |||
| */ | |||
| object: 'source_mandate_notification'; | |||
|
|
|||
| acss_debit?: SourceMandateNotification.AcssDebit; | |||
There was a problem hiding this comment.
This is in the spec for legacy reason even though it shouldn't be and fixing it is "too hard" so let's just ignore this part
| @@ -667,7 +667,7 @@ declare module 'stripe' { | |||
| /** | |||
| * The ID of the product that this price will belong to. | |||
| */ | |||
| product: string; | |||
| product?: string; | |||
There was a problem hiding this comment.
is this true? I'm seeing it as required still here: https://site-admin.stripe.com/docs/api/checkout/sessions/create#create_checkout_session-line_items-price_data-product
There was a problem hiding this comment.
yeah optional in the spec is finicky and it's really annoying but it's because they are preparing some beta where this is optional because you can pass product_data instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple API changes:
ae_trn,cl_tinandsa_vatastypeonTaxIdresultandresult_reasoninsidepayment_method_details[card][three_d_secure]onChargeCodegen for openapi cd33b40
r? @cjavilla-stripe
cc @stripe/api-libraries