Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple API changes #899

Merged
merged 1 commit into from
May 22, 2020
Merged

Multiple API changes #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion types/2020-03-02/Charges.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,18 +729,44 @@ declare module 'stripe' {
*/
authenticated?: boolean;

/**
* Indicates the outcome of 3D Secure authentication.
*/
result: ThreeDSecure.Result;

/**
* Additional information about why 3D Secure succeeded or failed.
*/
result_reason: ThreeDSecure.ResultReason | null;

/**
* Whether or not 3D Secure succeeded.
*/
succeeded?: boolean;

/**
* The version of 3D Secure that was used for this payment.
* The version of 3D Secure that was used.
*/
version: ThreeDSecure.Version;
}

namespace ThreeDSecure {
type Result =
| 'attempt_acknowledged'
| 'authenticated'
| 'failed'
| 'not_supported'
| 'processing_error';

type ResultReason =
| 'abandoned'
| 'bypassed'
| 'canceled'
| 'card_not_enrolled'
| 'network_not_supported'
| 'protocol_error'
| 'rejected';

type Version = '1.0.2' | '2.1.0' | '2.2.0';
}

Expand Down
2 changes: 1 addition & 1 deletion types/2020-03-02/Checkout/Sessions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ declare module 'stripe' {
/**
* The ID of the product that this price will belong to.
*/
product: string;
product?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true? I'm seeing it as required still here: https://site-admin.stripe.com/docs/api/checkout/sessions/create#create_checkout_session-line_items-price_data-product

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah optional in the spec is finicky and it's really annoying but it's because they are preparing some beta where this is optional because you can pass product_data instead


/**
* The recurring components of a price such as `interval` and `usage_type`.
Expand Down
5 changes: 4 additions & 1 deletion types/2020-03-02/Customers.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ declare module 'stripe' {

interface TaxIdDatum {
/**
* Type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, or `sg_gst`
* Type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, `sg_gst`, `ae_trn`, `cl_tin`, or `sa_vat`
*/
type: TaxIdDatum.Type;

Expand All @@ -353,12 +353,14 @@ declare module 'stripe' {

namespace TaxIdDatum {
type Type =
| 'ae_trn'
| 'au_abn'
| 'br_cnpj'
| 'br_cpf'
| 'ca_bn'
| 'ca_qst'
| 'ch_vat'
| 'cl_tin'
| 'es_cif'
| 'eu_vat'
| 'hk_br'
Expand All @@ -372,6 +374,7 @@ declare module 'stripe' {
| 'no_vat'
| 'nz_gst'
| 'ru_inn'
| 'sa_vat'
| 'sg_gst'
| 'sg_uen'
| 'th_vat'
Expand Down
5 changes: 4 additions & 1 deletion types/2020-03-02/Invoices.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ declare module 'stripe' {

interface CustomerTaxId {
/**
* The type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, `sg_gst`, or `unknown`
* The type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, `sg_gst`, `ae_trn`, `cl_tin`, `sa_vat`, or `unknown`
*/
type: CustomerTaxId.Type;

Expand All @@ -359,12 +359,14 @@ declare module 'stripe' {

namespace CustomerTaxId {
type Type =
| 'ae_trn'
| 'au_abn'
| 'br_cnpj'
| 'br_cpf'
| 'ca_bn'
| 'ca_qst'
| 'ch_vat'
| 'cl_tin'
| 'es_cif'
| 'eu_vat'
| 'hk_br'
Expand All @@ -378,6 +380,7 @@ declare module 'stripe' {
| 'no_vat'
| 'nz_gst'
| 'ru_inn'
| 'sa_vat'
| 'sg_gst'
| 'sg_uen'
| 'th_vat'
Expand Down
2 changes: 1 addition & 1 deletion types/2020-03-02/LineItems.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ declare module 'stripe' {
/**
* The taxes applied to the line item.
*/
taxes: Array<LineItem.Tax> | null;
taxes?: Array<LineItem.Tax>;
}

namespace LineItem {
Expand Down
9 changes: 9 additions & 0 deletions types/2020-03-02/SourceMandateNotifications.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ declare module 'stripe' {
*/
object: 'source_mandate_notification';

acss_debit?: SourceMandateNotification.AcssDebit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the spec for legacy reason even though it shouldn't be and fixing it is "too hard" so let's just ignore this part


/**
* A positive integer in the smallest currency unit (that is, 100 cents for $1.00, or 1 for ¥1, Japanese Yen being a zero-decimal currency) representing the amount associated with the mandate notification. The amount is expressed in the currency of the underlying source. Required if the notification type is `debit_initiated`.
*/
Expand Down Expand Up @@ -60,6 +62,13 @@ declare module 'stripe' {
}

namespace SourceMandateNotification {
interface AcssDebit {
/**
* The statement descriptor associate with the debit.
*/
statement_descriptor?: string;
}

interface BacsDebit {
/**
* Last 4 digits of the account number associated with the debit.
Expand Down
10 changes: 8 additions & 2 deletions types/2020-03-02/TaxIds.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ declare module 'stripe' {
livemode: boolean;

/**
* Type of the tax ID, one of `au_abn`, `br_cnpj`, `br_cpf`, `ca_bn`, `ca_qst`, `ch_vat`, `es_cif`, `eu_vat`, `hk_br`, `in_gst`, `jp_cn`, `kr_brn`, `li_uid`, `mx_rfc`, `my_itn`, `my_sst`, `no_vat`, `nz_gst`, `ru_inn`, `sg_gst`, `sg_uen`, `th_vat`, `tw_vat`, `us_ein`, or `za_vat`. Note that some legacy tax IDs have type `unknown`
* Type of the tax ID, one of `ae_trn`, `au_abn`, `br_cnpj`, `br_cpf`, `ca_bn`, `ca_qst`, `ch_vat`, `cl_tin`, `es_cif`, `eu_vat`, `hk_br`, `in_gst`, `jp_cn`, `kr_brn`, `li_uid`, `mx_rfc`, `my_itn`, `my_sst`, `no_vat`, `nz_gst`, `ru_inn`, `sa_vat`, `sg_gst`, `sg_uen`, `th_vat`, `tw_vat`, `us_ein`, or `za_vat`. Note that some legacy tax IDs have type `unknown`
*/
type: TaxId.Type;

Expand All @@ -51,12 +51,14 @@ declare module 'stripe' {

namespace TaxId {
type Type =
| 'ae_trn'
| 'au_abn'
| 'br_cnpj'
| 'br_cpf'
| 'ca_bn'
| 'ca_qst'
| 'ch_vat'
| 'cl_tin'
| 'es_cif'
| 'eu_vat'
| 'hk_br'
Expand All @@ -70,6 +72,7 @@ declare module 'stripe' {
| 'no_vat'
| 'nz_gst'
| 'ru_inn'
| 'sa_vat'
| 'sg_gst'
| 'sg_uen'
| 'th_vat'
Expand Down Expand Up @@ -122,7 +125,7 @@ declare module 'stripe' {

interface TaxIdCreateParams {
/**
* Type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, or `sg_gst`
* Type of the tax ID, one of `eu_vat`, `br_cnpj`, `br_cpf`, `nz_gst`, `au_abn`, `in_gst`, `no_vat`, `za_vat`, `ch_vat`, `mx_rfc`, `sg_uen`, `ru_inn`, `ca_bn`, `hk_br`, `es_cif`, `tw_vat`, `th_vat`, `jp_cn`, `li_uid`, `my_itn`, `us_ein`, `kr_brn`, `ca_qst`, `my_sst`, `sg_gst`, `ae_trn`, `cl_tin`, or `sa_vat`
*/
type: TaxIdCreateParams.Type;

Expand All @@ -139,12 +142,14 @@ declare module 'stripe' {

namespace TaxIdCreateParams {
type Type =
| 'ae_trn'
| 'au_abn'
| 'br_cnpj'
| 'br_cpf'
| 'ca_bn'
| 'ca_qst'
| 'ch_vat'
| 'cl_tin'
| 'es_cif'
| 'eu_vat'
| 'hk_br'
Expand All @@ -158,6 +163,7 @@ declare module 'stripe' {
| 'no_vat'
| 'nz_gst'
| 'ru_inn'
| 'sa_vat'
| 'sg_gst'
| 'sg_uen'
| 'th_vat'
Expand Down