Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server with IPv6 enabled, but domain has no AAAA record throws an error #1045

Closed
Noodleyman opened this issue Nov 16, 2020 · 0 comments · Fixed by #1046
Closed

Server with IPv6 enabled, but domain has no AAAA record throws an error #1045

Noodleyman opened this issue Nov 16, 2020 · 0 comments · Fixed by #1046

Comments

@Noodleyman
Copy link

Noodleyman commented Nov 16, 2020

If the web server on which the sites are hosted has IPv6 support, but the domain using Stripe itself has no AAAA DNS record, then the library CURL request can fail with error:

Uncaught (in promise) SyntaxError: Unexpected end of JSON input

to work around it, I forced the CURL request in CurlClient.php to use IPv4 only, however ideally this should be handled better with IPv6 detection an AAAA record validation.

I consider this an edge case, although with IPv6 becoming more common, I've seen this catch out at least two stores which depend on this library. both required the adjustment to force IPv4 use (or, both could also have been setup for IPv6 properly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant