Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8 #1185

Closed
tin-cat opened this issue Oct 2, 2021 · 7 comments
Closed

Support PHP 8 #1185

tin-cat opened this issue Oct 2, 2021 · 7 comments
Assignees

Comments

@tin-cat
Copy link

tin-cat commented Oct 2, 2021

As PHP 8 gradually becomes the new standard for PHP-based applications, more and more developers and server environments are welcoming the performance improvements of JIT and the many new tools that make PHP development easier and powerful as ever.

Unfortunately stripe-php is not compatible yet with PHP 8, specially suffering from issues related to certain deprecated function usages and type constrains like #1125

I'm sure many developers would love to be able to use this library in their new PHP 8-based environments. Being Stripe so widely used, this would also encourage more developers to adopt PHP 8 in their projects.

Thank you.

@remi-stripe
Copy link
Contributor

@tin-cat Thanks for the report! We'll see if we can work on PHP8 compatibility and then add it to our test suite, there shouldn't be too many drastic changes in the library and we agree we should be supporting the latest major versions of all languages

@tin-cat
Copy link
Author

tin-cat commented Oct 2, 2021

That would be fantastic! So much thanks for such a great work!

@MatanYadaev
Copy link

@remi-stripe PHP 8.1 is out. Any progress with that?

@BenMorel
Copy link

BenMorel commented Dec 4, 2021

Stripe is already 1 year behind. Could you please add support for both PHP 8.0 and 8.1 ASAP? Thank you.

@richardm-stripe
Copy link
Contributor

richardm-stripe commented Dec 6, 2021

Hello @tin-cat, @BenMorel, and @MatanYadaev

As of v7.105.0 we are now running our test suites and static analyzers on PHP 8 and PHP 8.1, and thanks to #1213 we should have added all the necessary compatibility annotations for PHP8.1. Are you aware of any particular incompatibilities that remain beyond this? I've looked into #1125 and cannot reproduce it.

@BenMorel
Copy link

BenMorel commented Dec 6, 2021

@richardm-stripe Works fine for me (no more deprecation warnings) with v7.105.0, thanks!

@richardm-stripe
Copy link
Contributor

Thank you @BenMorel.

I am closing this issue. This library now officially supports PHP 8.1.

We already have a large number of users who appear to have successfully been using PHP8 in production and a sizeable number that have adopted PHP8.1 despite the deprecation warnings.

Any further compatibility issues will be treated as urgent bugs.

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants