-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for "book", "buy", "checkout", "donate", "order" as type in GooglePayButton component #855
Comments
Also a black button for Google Pay for white backgrounds. Now there is only a white option with or without shadows. |
This is a great request, although I'll need to think about it a little bit. I believe we can add the assets to this library, and although it will expand the size of the npm module you download, as long as people enable resource shrinking on Android, it should have no effect on final app size (but I'd want to test that out to be sure). |
Any updates on the ability to style the GooglePayButton to dark or black mode please? Google Pay & Wallet Console is requesting we do this to be able to grant us the integration. Thank you. |
Hi, I haven't been working on this and it's not immediately planned Rather than adding in these assets to this library itself, the plan is to find if Google provides a friendlier asset type for the google pay button as they have with the "add to google pay" button - https://developers.google.com/pay/issuers/apis/push-provisioning/android/branding-guidelines#flutter (they're providing it for flutter, but it's also much nicer for RN). I'd be surprised if they didn't, and this will make it much easier for folks to customize this button |
Dark buttons will be made available in #1051 |
Just wanted to ask, have you found friendlier asset types for these buttons? I think besides using "donate" it would also allow us to use |
The new asset types for PlatformPayButton offer |
Thanks for the heads up! Unfortunately I can't upgrade to that version yet, as the latest Expo SDK version is incompatible, but will keep it in mind for when it is. Google have gotten back to me and they indeed require the latest guidelines, so for now I'll just use a static image |
I am working on an app that has allows its user to donate using Google Pay. So the "Pay with G Pay" text on the button just doesn't sound right. It would have been nice if all types were supported.
The text was updated successfully, but these errors were encountered: