Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Address Element 🏘 #1169

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Oct 12, 2022

Summary

  • Added the <AddressSheet /> component, which enables you to collect local and international shipping or billing addresses from your customers with address autocomplete. #1169
  • Added the defaultShippingDetails field to the params argument in initPaymentSheet(params). This will allow you to collect shipping details (either in your own UI or using the new <AddressSheet /> component) for payments in the Payment Sheet. #1169

Motivation

beta release the AddressElement

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

Comment on lines +138 to +143
implementation ('com.github.stripe:stripe-android:address-element-private-beta-SNAPSHOT') {
exclude group: 'com.github.stripe.stripe-android', module: 'stripecardscan-tflite'
exclude group: 'com.github.stripe.stripe-android', module: 'stripecardscan'
}

// implementation "com.stripe:financial-connections:$stripe_version"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert

@@ -44,7 +44,7 @@ allprojects {
url("$rootDir/../node_modules/jsc-android/dist")
}
maven { url "file:/$rootDir/privateMavenRepository" }

maven { url 'https://jitpack.io' }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert

Comment on lines -19 to +31
:production => production,
production: production,
hermes_enabled: flags[:hermes_enabled],
fabric_enabled: flags[:fabric_enabled],
:flipper_configuration => FlipperConfiguration.enabled,
flipper_configuration: FlipperConfiguration.enabled,
# An absolute path to your application root.
app_path: "#{Pod::Config.instance.installation_root}/.."
)

pod 'Stripe', git: 'https://github.com/stripe-ios/stripe-ios.git', branch: 'address-element-private-beta'
pod 'StripeUICore', git: 'https://github.com/stripe-ios/stripe-ios.git', branch: 'address-element-private-beta'
pod 'StripeCore', git: 'https://github.com/stripe-ios/stripe-ios.git', branch: 'address-element-private-beta'
pod 'StripeFinancialConnections', git: 'https://github.com/stripe-ios/stripe-ios.git', branch: 'address-element-private-beta'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert

Comment on lines +25 to +26
s.dependency 'Stripe'
s.dependency 'StripeFinancialConnections'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert

@charliecruzan-stripe charliecruzan-stripe changed the base branch from master to address-element-private-beta October 12, 2022 23:28
@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review October 14, 2022 00:25
@charliecruzan-stripe charliecruzan-stripe removed the request for review from acomley-stripe October 14, 2022 00:25
@charliecruzan-stripe charliecruzan-stripe merged commit a134c78 into address-element-private-beta Oct 14, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/shippingaddresselement branch October 14, 2022 00:26
@charliecruzan-stripe charliecruzan-stripe mentioned this pull request Nov 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant