Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly pass back token for push provisioning yellow path on android #1282

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fix: correctly pass back token for push provisioning yellow path on android #1282

merged 2 commits into from
Feb 2, 2023

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

token is now added regardless of the value of canAddCard, whereas previously it was only added to the details map if canAddCard was false.

Motivation

In the "yellow path" on android, canAddCard is actually true

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 7a4c850 into master Feb 2, 2023
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/fix-tokenize=android branch February 2, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliecruzan-stripe